Start line:  
End line:  

Snippet Preview

Snippet HTML Code

Stack Overflow Questions
 /*
  * fb-contrib - Auxiliary detectors for Java programs
  * Copyright (C) 2005-2012 Bhaskar Maddala
  * Copyright (C) 2005-2012 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
  * version 2.1 of the License, or (at your option) any later version.
 * 
 * This library is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 * Lesser General Public License for more details.
 * 
 * You should have received a copy of the GNU Lesser General Public
 * License along with this library; if not, write to the Free Software
 * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
 */
package com.mebigfatguy.fbcontrib.detect;
import  org.apache.bcel.classfile.Code;
import  org.apache.bcel.classfile.LocalVariableTable;
import  edu.umd.cs.findbugs.BugInstance;
import  edu.umd.cs.findbugs.BugReporter;
import  edu.umd.cs.findbugs.BytecodeScanningDetector;
import  edu.umd.cs.findbugs.OpcodeStack;

Find usage of HashCodeBuilder from Apache commons, where the code invokes hashCode() on the constructed object rather than toHashCode()
 new HashCodeBuilder().append(this.name).hashCode();
 
public class CommonsHashcodeBuilderToHashcode extends BytecodeScanningDetector {
	private final OpcodeStack stack;
	private final BugReporter bugReporter;

constructs a CHTH detector given the reporter to report bugs on.

Parameters:
bugReporter the sync of bug reports
	public CommonsHashcodeBuilderToHashcode(final BugReporter bugReporter) {
		 = new OpcodeStack();
		this. = bugReporter;
	}

implements the visitor to pass through constructors and static initializers to the byte code scanning code. These methods are not reported, but are used to build SourceLineAnnotations for fields, if accessed.

Parameters:
obj the context object of the currently parsed code attribute
	public void visitCode(Code obj) {
		.resetForMethodEntry(this);
		LocalVariableTable lvt = getMethod().getLocalVariableTable();
		if (lvt != null) {
			super.visitCode(obj);
		}
	}
	public void sawOpcode(int seen) {
		try {
			switch (seen) {
			case INVOKEVIRTUAL:
				String methodName = getNameConstantOperand();
				if ("hashCode".equals(methodName)
					String calledClass = .getStackItem(0).getSignature();
					if ("Lorg/apache/commons/lang3/builder/HashCodeBuilder;"
							.equals(calledClass)
							|| "org/apache/commons/lang/builder/HashCodeBuilder"
									.equals(calledClass)) {
						.reportBug(new BugInstance(this,
								"CHTH_COMMONS_HASHCODE_BUILDER_TOHASHCODE",
								HIGH_PRIORITY).addClass(this).addMethod(this)
								.addSourceLine(this));
					}
				}
			}
finally {
			super.sawOpcode(seen);
			.sawOpcode(thisseen);
		}
	}
New to GrepCode? Check out our FAQ X